fix(api): Retry API requests on DNS resolution failure #3085
+44
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Retry API requests on DNS resolution failure ([#3085](https://github.com/getsentry/sentry-cli/pull/3085))If none of the above apply, you can opt out of this check by adding |
When DNS resolution fails (CURLE_COULDNT_RESOLVE_HOST), the CLI now retries the request using the existing exponential backoff retry mechanism. This addresses intermittent DNS failures that were causing ~5-10% of builds to fail. Fixes #2763 Co-Authored-By: Claude Opus 4.5 <[email protected]>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dns
branch
from
e5f8b7e to
e6938fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When DNS resolution fails (
CURLE_COULDNT_RESOLVE_HOST), the CLI now retries the request using the existing exponential backoff retry mechanism. This addresses intermittent DNS failures that were causing ~5-10% of builds to fail for some users uploading symbol files.The implementation:
RetryableCurlErrortype to wrap curl errors that should trigger retriescurl::Error::is_couldnt_resolve_host()RetryableCurlErroralongside HTTP status code retriesIssues